Skip to content

Refactor FXIOS-12796 [Swift 6 Migration] Fix main actor isolation warnings that are Swift 6 errors in the XCUITests suite - Batch 1#31025

Merged
ih-codes merged 2 commits intomainfrom
ih/FXIOS-12796-XCUITests-batch-1
Dec 1, 2025
Merged

Refactor FXIOS-12796 [Swift 6 Migration] Fix main actor isolation warnings that are Swift 6 errors in the XCUITests suite - Batch 1#31025
ih-codes merged 2 commits intomainfrom
ih/FXIOS-12796-XCUITests-batch-1

Conversation

@ih-codes
Copy link
Collaborator

@ih-codes ih-codes commented Dec 1, 2025 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

Fix main actor isolation warnings that are Swift 6 errors in the XCUITests suite.

  • Isolate all UI tests to the main thread via BaseTestCase inheritance
  • Isolate each PageScreens/*Screen.swift file to the main thread

This takes the XCUITest suite from over 11,000 warnings to 950 🎉
Screenshot 2025-12-01 at 1 21 49 PM ▶️ Screenshot 2025-12-01 at 1 18 55 PM

cc @Cramsden @lmarceau @dataports

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@ih-codes ih-codes requested a review from dataports December 1, 2025 19:22
@ih-codes ih-codes marked this pull request as ready for review December 1, 2025 19:23
@ih-codes ih-codes requested a review from a team as a code owner December 1, 2025 19:23
@ih-codes ih-codes requested a review from clarmso December 1, 2025 19:23
clarmso
clarmso approved these changes Dec 1, 2025
View reviewed changes
Copy link
Collaborator

@clarmso clarmso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 @ih-codes Let's fix all the warnings. Let me know if you need any help.

@ih-codes
Copy link
Collaborator Author

ih-codes commented Dec 1, 2025

Thanks @clarmso!! I will let you know if/as we come across any tough warnings. 😁

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Dec 1, 2025

💪 Quality guardian

36 tests files modified. You're a champion of test coverage! 🚀

🌱 Tiny but mighty

Only 39 line(s) changed. Fast to review, faster to land! 🚀

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Generated by 🚫 Danger Swift against be17b0c

@ih-codes
Copy link
Collaborator Author

ih-codes commented Dec 1, 2025

Bitrise succeeded! 🎉 🎉 🎉

@ih-codes ih-codes merged commit 1737c46 into main Dec 1, 2025
9 checks passed
@ih-codes ih-codes deleted the ih/FXIOS-12796-XCUITests-batch-1 branch December 1, 2025 19:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

🚀 PR merged to main, targeting version: 146.1

This was referenced Dec 1, 2025
Merged
Merged
This was referenced Jan 21, 2026
Closed
Closed
Closed
Closed
This was referenced Jan 21, 2026
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarmso clarmso clarmso approved these changes

@dataports dataports Awaiting requested review from dataports

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ih-codes @mobiletest-ci-bot @clarmso